]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ASoC: codecs: va-macro: fix revision checking
authorSrinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
Wed, 29 Oct 2025 14:43:35 +0000 (14:43 +0000)
committerMark Brown <broonie@kernel.org>
Wed, 29 Oct 2025 20:14:45 +0000 (20:14 +0000)
The revision rework patch seems to have reversed the bit positions for
macro presence in core_id_1 register.

This broken RB1 and Arduino UnoQ audio.
Fix these bit positions to correctly reflect the register definition.

Fixes: 281c97376cfc ("ASoC: codecs: va-macro: Rework version checking")
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
Link: https://patch.msgid.link/20251029144336.356816-1-srinivas.kandagatla@oss.qualcomm.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/lpass-va-macro.c

index 2b0ecc52c6be668266c890a942a5a4ba2765762e..fbe5ebeeaa805439638a88cf9d9605154753dcee 100644 (file)
 #define CDC_VA_TOP_CSR_CORE_ID_0               (0x00C0)
  #define CORE_ID_0_REV_MAJ                     GENMASK(7, 0)
 #define CDC_VA_TOP_CSR_CORE_ID_1               (0x00C4)
-#define CORE_ID_1_HAS_WSAMACRO                 BIT(3)
-#define CORE_ID_1_HAS_RXMACRO                  BIT(2)
-#define CORE_ID_1_HAS_TXMACRO                  BIT(1)
-#define CORE_ID_1_HAS_VAMACRO                  BIT(0)
+#define CORE_ID_1_HAS_WSAMACRO                 BIT(0)
+#define CORE_ID_1_HAS_RXMACRO                  BIT(1)
+#define CORE_ID_1_HAS_TXMACRO                  BIT(2)
+#define CORE_ID_1_HAS_VAMACRO                  BIT(3)
 #define CDC_VA_TOP_CSR_CORE_ID_2               (0x00C8)
  #define CORE_ID_2_REV_MIN                     GENMASK(7, 4)
  #define CORE_ID_2_REV_STEP                    GENMASK(3, 0)