backends: Always set *prefix to "" when not used in register_info hook.

For ia64 and tilegx *prefix was already set to the empty string, but
arm, ppc and sh used NULL to indicate no prefix preceded the register
name in the canonical assembler syntax. Consistently use the empty string
in all backends since dwfl_module_register_names says: 'a prefix used in
assembler syntax (such as "%" or "$", may be "")'. So users had to handle
the empty string already, and might forget to handle the NULL case
(like our own addrcfi testcase).

Signed-off-by: Mark Wielaard <mjw@redhat.com>

diff --git a/backends/ChangeLog b/backends/ChangeLog
index 4f7480d812550a09d3e6076bb07f5428e0f2c2d2..0863b566285057772d9e867e5e0a005b4662a695 100644 (file)
--- a/backends/ChangeLog
+++ b/backends/ChangeLog
@@ -1,3 +1,9 @@
+2013-08-28  Mark Wielaard  <mjw@redhat.com>
+
+       * arm_regs.c (arm_register_info): Set *prefix to "".
+       * ppc_regs.c (ppc_register_info): Likewise.
+       * sh_regs.c (sh_register_info): Likewise.
+
 2013-04-24  Mark Wielaard  <mjw@redhat.com>
 
        * Makefile.am: Use AM_CPPFLAGS instead of INCLUDES.

diff --git a/backends/arm_regs.c b/backends/arm_regs.c
index 0155149eaad83f241e96b2c9b3f424cad6e67bd3..21c5ad3a18fbca6ee67b5eac6ebf73cab566bdbd 100644 (file)
--- a/backends/arm_regs.c
+++ b/backends/arm_regs.c
@@ -48,7 +48,7 @@ arm_register_info (Ebl *ebl __attribute__ ((unused)),
   if (regno < 0 || regno > 320 || namelen < 5)
     return -1;
 
-  *prefix = NULL;
+  *prefix = "";
   *bits = 32;
   *type = DW_ATE_signed;
   *setname = "integer";

diff --git a/backends/ppc_regs.c b/backends/ppc_regs.c
index 9c2d7e853657cf955327b0a2266af5bbd279d9ca..4b92a9aa98c4b6686d45b175150535eb0de13002 100644 (file)
--- a/backends/ppc_regs.c
+++ b/backends/ppc_regs.c
@@ -48,7 +48,7 @@ ppc_register_info (Ebl *ebl __attribute__ ((unused)),
   if (regno < 0 || regno > 1155 || namelen < 8)
     return -1;
 
-  *prefix = NULL;
+  *prefix = "";
   *bits = ebl->machine == EM_PPC64 ? 64 : 32;
   *type = (regno < 32 ? DW_ATE_signed
           : regno < 64 ? DW_ATE_float : DW_ATE_unsigned);

diff --git a/backends/sh_regs.c b/backends/sh_regs.c
index 3d323a913f90d9b1cf0bd700c8c0595a4e30611d..d4332364a8ba8f04f169127022ab28c22b1d55c1 100644 (file)
--- a/backends/sh_regs.c
+++ b/backends/sh_regs.c
@@ -50,7 +50,7 @@ sh_register_info (Ebl *ebl __attribute__ ((unused)),
   if (regno < 0 || regno > 103 || namelen < 6)
     return -1;
 
-  *prefix = NULL;
+  *prefix = "";
   *bits = 32;
   *type = DW_ATE_signed;