]> git.ipfire.org Git - thirdparty/squid.git/commitdiff
Initialize mem_node fully
authorAmos Jeffries <squid3@treenet.co.nz>
Tue, 15 Jan 2013 01:01:30 +0000 (18:01 -0700)
committerAmos Jeffries <squid3@treenet.co.nz>
Tue, 15 Jan 2013 01:01:30 +0000 (18:01 -0700)
Experience in squid-2.7 shows that with MemPools use of malloc instead
of calloc mem_node requires full initialization in order to get accurate
memory accounting.

Also closes Coverity Scan defect issue 740573.

src/mem_node.cc

index 16412ed0f007a8bd5b03ca92e294519ec0a29d21..dc59c3049f303ac74c423d0c2b6dba0cfb222b92 100644 (file)
@@ -63,8 +63,12 @@ memNodeWriteComplete(void* d)
     n->write_pending = 0;
 }
 
-mem_node::mem_node(int64_t offset):nodeBuffer(0,offset,data)
-{}
+mem_node::mem_node(int64_t offset) :
+        nodeBuffer(0,offset,data),
+        write_pending(0)
+{
+    *data = 0;
+}
 
 mem_node::~mem_node()
 {}