]> git.ipfire.org Git - thirdparty/suricata.git/commitdiff
app-layer-ssl: remove possibility to overflow HAS_SPACE macro
authorMats Klepsland <mats.klepsland@gmail.com>
Wed, 28 Mar 2018 21:26:20 +0000 (23:26 +0200)
committerVictor Julien <victor@inliniac.net>
Fri, 30 Mar 2018 07:25:02 +0000 (09:25 +0200)
src/app-layer-ssl.c

index df39555de3b5ac6756ccea8f3bc254b612dfa29d..fe8830e82dddbca5ee5c81fcbd15414f82b89836 100644 (file)
@@ -143,7 +143,7 @@ SslConfig ssl_config;
 
 #define SHA1_STRING_LENGTH             60
 
-#define HAS_SPACE(n) ((uint32_t)((input) + (n) - (initial_input)) > (uint32_t)(input_len)) ?  0 : 1
+#define HAS_SPACE(n) ((uint64_t)(input - initial_input) + (uint64_t)(n) > (uint64_t)(input_len)) ?  0 : 1
 
 static void SSLParserReset(SSLState *ssl_state)
 {