]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drm/amdgpu: fix warning for potentially insecure string
authorSunil Khatri <sunil.khatri@amd.com>
Fri, 6 Mar 2026 11:18:02 +0000 (16:48 +0530)
committerAlex Deucher <alexander.deucher@amd.com>
Fri, 6 Mar 2026 21:33:51 +0000 (16:33 -0500)
linux/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c:2358:24: warning: format string is not a string literal (potentially insecure) [-Wformat-security]
                         sprintf(ring->name, amdgpu_sw_ring_name(i));
                                             ^~~~~~~~~~~~~~~~~~~~~~
linux/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c:2358:24: note: treat the string as an argument to avoid this
                         sprintf(ring->name, amdgpu_sw_ring_name(i));

Signed-off-by: Sunil Khatri <sunil.khatri@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c

index 7e9d753f4a808d21180986ee5d2b588da712c24f..95be105671ece88029e55adff4dae95d21fe20e0 100644 (file)
@@ -2355,7 +2355,7 @@ static int gfx_v9_0_sw_init(struct amdgpu_ip_block *ip_block)
                for (i = 0; i < GFX9_NUM_SW_GFX_RINGS; i++) {
                        ring = &adev->gfx.sw_gfx_ring[i];
                        ring->ring_obj = NULL;
-                       sprintf(ring->name, amdgpu_sw_ring_name(i));
+                       strscpy(ring->name, amdgpu_sw_ring_name(i), sizeof(ring->name));
                        ring->use_doorbell = true;
                        ring->doorbell_index = adev->doorbell_index.gfx_ring0 << 1;
                        ring->is_sw_ring = true;