]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
reset: imx8mp-audiomix: Drop unneeded macros
authorLaurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
Wed, 26 Nov 2025 12:42:14 +0000 (04:42 -0800)
committerPhilipp Zabel <p.zabel@pengutronix.de>
Sat, 24 Jan 2026 15:22:49 +0000 (16:22 +0100)
The macros defining the mask values for the EARC, EARC PHY resets,
and the DSP RUN_STALL signal can be dropped as they are not and will
not be used anywhere else except to set the value of the "mask" field
from "struct imx8mp_reset_map". In this particular case, based on the
name of the "mask" field, you can already deduce what these values are
for, which is why defining macros for them doesn't offer any new
information, nor does it help with the code readability.

Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
drivers/reset/reset-imx8mp-audiomix.c

index eceb37ff5dc5b5ed721f5de886e7d1e2ddc04847..acfa92b153293a1d90d9e059ee3d786a89770911 100644 (file)
@@ -6,6 +6,7 @@
 #include <dt-bindings/reset/imx8mp-reset-audiomix.h>
 
 #include <linux/auxiliary_bus.h>
+#include <linux/bits.h>
 #include <linux/device.h>
 #include <linux/io.h>
 #include <linux/module.h>
 #include <linux/reset-controller.h>
 
 #define IMX8MP_AUDIOMIX_EARC_RESET_OFFSET      0x200
-#define IMX8MP_AUDIOMIX_EARC_RESET_MASK                BIT(0)
-#define IMX8MP_AUDIOMIX_EARC_PHY_RESET_MASK    BIT(1)
-
 #define IMX8MP_AUDIOMIX_DSP_RUNSTALL_OFFSET    0x108
-#define IMX8MP_AUDIOMIX_DSP_RUNSTALL_MASK      BIT(5)
 
 struct imx8mp_reset_map {
        unsigned int offset;
@@ -29,17 +26,17 @@ struct imx8mp_reset_map {
 static const struct imx8mp_reset_map reset_map[] = {
        [IMX8MP_AUDIOMIX_EARC_RESET] = {
                .offset = IMX8MP_AUDIOMIX_EARC_RESET_OFFSET,
-               .mask   = IMX8MP_AUDIOMIX_EARC_RESET_MASK,
+               .mask = BIT(0),
                .active_low = true,
        },
        [IMX8MP_AUDIOMIX_EARC_PHY_RESET] = {
                .offset = IMX8MP_AUDIOMIX_EARC_RESET_OFFSET,
-               .mask   = IMX8MP_AUDIOMIX_EARC_PHY_RESET_MASK,
+               .mask = BIT(1),
                .active_low = true,
        },
        [IMX8MP_AUDIOMIX_DSP_RUNSTALL] = {
                .offset = IMX8MP_AUDIOMIX_DSP_RUNSTALL_OFFSET,
-               .mask   = IMX8MP_AUDIOMIX_DSP_RUNSTALL_MASK,
+               .mask = BIT(5),
                .active_low = false,
        },
 };