btrfs: inode-item: remove unnecessary calls to btrfs_mark_buffer_dirty()

We have several places explicitly calling btrfs_mark_buffer_dirty() but
that is not necessarily since the target leaf came from a path that was
obtained for a btree search function that modifies the btree, something
like btrfs_insert_empty_item() or anything else that ends up calling
btrfs_search_slot() with a value of 1 for its 'cow' argument.

These just make the code more verbose, confusing and add a little extra
overhead and well as increase the module's text size, so remove them.

Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Signed-off-by: Filipe Manana <fdmanana@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>

diff --git a/fs/btrfs/inode-item.c b/fs/btrfs/inode-item.c
index 29572dfaf8785c05d97a00125acb4bff29b95594..448aa1a682d6019a85e1ddc7c158ba1e5b2cd3eb 100644 (file)
--- a/fs/btrfs/inode-item.c
+++ b/fs/btrfs/inode-item.c
@@ -298,8 +298,6 @@ static int btrfs_insert_inode_extref(struct btrfs_trans_handle *trans,
 
        ptr = (unsigned long)&extref->name;
        write_extent_buffer(path->nodes[0], name->name, ptr, name->len);
-       btrfs_mark_buffer_dirty(trans, path->nodes[0]);
-
 out:
        btrfs_free_path(path);
        return ret;
@@ -363,8 +361,6 @@ int btrfs_insert_inode_ref(struct btrfs_trans_handle *trans,
                ptr = (unsigned long)(ref + 1);
        }
        write_extent_buffer(path->nodes[0], name->name, ptr, name->len);
-       btrfs_mark_buffer_dirty(trans, path->nodes[0]);
-
 out:
        btrfs_free_path(path);
 
@@ -590,7 +586,6 @@ search_again:
                                num_dec = (orig_num_bytes - extent_num_bytes);
                                if (extent_start != 0)
                                        control->sub_bytes += num_dec;
-                               btrfs_mark_buffer_dirty(trans, leaf);
                        } else {
                                extent_num_bytes =
                                        btrfs_file_extent_disk_num_bytes(leaf, fi);