]> git.ipfire.org Git - thirdparty/vala.git/commitdiff
codegen: Trigger deprecation warning for NoArrayLength from a better place
authorRico Tzschichholz <ricotz@ubuntu.com>
Tue, 11 Oct 2016 13:21:41 +0000 (15:21 +0200)
committerRico Tzschichholz <ricotz@ubuntu.com>
Tue, 11 Oct 2016 14:55:52 +0000 (16:55 +0200)
codegen/valaccodeattribute.vala
codegen/valaccodemethodmodule.vala
vala/valausedattr.vala

index f9c9ab6e79eceacc439766edab558b51e2638921..d7cb200591fad52399c82fc94e0d49927a8050b6 100644 (file)
@@ -473,7 +473,7 @@ public class Vala.CCodeAttribute : AttributeCache {
                get {
                        if (_array_length == null) {
                                if (node.get_attribute ("NoArrayLength") != null) {
-                                       // deprecated
+                                       Report.deprecated (node.source_reference, "[NoArrayLength] is deprecated, use [CCode (array_length = false)] instead.");
                                        _array_length = false;
                                } else if (ccode != null && ccode.has_argument ("array_length")) {
                                        _array_length = ccode.get_bool ("array_length");
index aa2ab5c8c2ed0c77a9a0ae8da9d79229ddcd0251..9c8e92136697d25b23edb61020a9608c3677d0bf 100644 (file)
@@ -306,10 +306,6 @@ public abstract class Vala.CCodeMethodModule : CCodeStructModule {
 
                bool profile = m.get_attribute ("Profile") != null;
 
-               if (m.get_attribute ("NoArrayLength") != null) {
-                       Report.deprecated (m.source_reference, "NoArrayLength attribute is deprecated, use [CCode (array_length = false)] instead.");
-               }
-
                if (m is CreationMethod) {
                        var cl = current_type_symbol as Class;
                        if (cl != null && !cl.is_compact) {
index 14cdd97b9be2041da62ef4651cb4a3f268562776..14fe1d20be29579991072770bf7a4c8aa2358869 100644 (file)
@@ -48,6 +48,7 @@ public class Vala.UsedAttr : CodeVisitor {
                "Flags", "",
                "Experimental", "",
                "NoReturn", "",
+               "NoArrayLength", "", // deprecated
                "Assert", "",
                "ErrorBase", "",
                "GenericAccessors", "",