]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
net: usb: usbnet: fix race in probe failure
authorOliver Neukum <oneukum@suse.com>
Thu, 10 Oct 2024 13:19:14 +0000 (15:19 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 1 Nov 2024 00:52:33 +0000 (01:52 +0100)
[ Upstream commit b62f4c186c70aa235fef2da68d07325d85ca3ade ]

The same bug as in the disconnect code path also exists
in the case of a failure late during the probe process.
The flag must also be set.

Signed-off-by: Oliver Neukum <oneukum@suse.com>
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Link: https://patch.msgid.link/20241010131934.1499695-1-oneukum@suse.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/usb/usbnet.c

index 47a587dae74634dd272744393219f10ca4a2dbbd..2945e336505bf88c36b0b5af9b96d5479f761dc8 100644 (file)
@@ -1872,6 +1872,7 @@ out1:
         * may trigger an error resubmitting itself and, worse,
         * schedule a timer. So we kill it all just in case.
         */
+       usbnet_mark_going_away(dev);
        cancel_work_sync(&dev->kevent);
        del_timer_sync(&dev->delay);
        free_percpu(net->tstats);