]> git.ipfire.org Git - thirdparty/sqlalchemy/sqlalchemy.git/commitdiff
- changelog for pr bitbucket:70, fixes #3624
authorMike Bayer <mike_mp@zzzcomputing.com>
Tue, 12 Jan 2016 14:53:09 +0000 (09:53 -0500)
committerMike Bayer <mike_mp@zzzcomputing.com>
Tue, 12 Jan 2016 14:53:09 +0000 (09:53 -0500)
doc/build/changelog/changelog_10.rst
test/dialect/mssql/test_types.py

index 4d017cfb15fb338cadf7ee92f08b9d10500675bb..c465c73ed1c2cdc9f2406aab0ad216bb6c578843 100644 (file)
     :version: 1.0.12
     :released:
 
+    .. change::
+        :tags: bug, mssql
+        :tickets: 3624
+        :pullreq: bitbucket:70
+
+        Fixed the syntax of the :func:`.extract` function when used on
+        MSSQL against a datetime value; the quotes around the keyword
+        are removed.  Pull request courtesy Guillaume Doumenc.
+
     .. change::
         :tags: bug, orm
         :tickets: 3623
index dad86c60a71bcbebf02a1516445e703e9aa1b837..100e4e0edb16cb4a15c8fc6d84b6ea0e0ec0bdf3 100644 (file)
@@ -64,6 +64,18 @@ class MSDateTypeTest(fixtures.TestBase):
             result_processor, 'abc'
         )
 
+    def test_extract(self):
+        from sqlalchemy import extract
+        fivedaysago = datetime.datetime.now() \
+            - datetime.timedelta(days=5)
+        for field, exp in ('year', fivedaysago.year), \
+                ('month', fivedaysago.month), ('day', fivedaysago.day):
+            r = testing.db.execute(
+                select([
+                    extract(field, fivedaysago)])
+            ).scalar()
+            eq_(r, exp)
+
 
 class TypeDDLTest(fixtures.TestBase):