]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
wifi: mt76: mt7996: Remove useless check in mt7996_msdu_page_get_from_cache()
authorLorenzo Bianconi <lorenzo@kernel.org>
Tue, 14 Oct 2025 13:28:53 +0000 (15:28 +0200)
committerFelix Fietkau <nbd@nbd.name>
Mon, 24 Nov 2025 13:37:54 +0000 (14:37 +0100)
Get rid of useless null-pointer check in mt7996_msdu_page_get_from_cache
since we have already verfied the list is not empty.

Fixes: b1e58e137b616 ("wifi: mt76: mt7996: Introduce RRO MSDU callbacks")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/r/202510100155.MS0IXhzm-lkp@intel.com/
Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
Link: https://patch.msgid.link/20251014-mt7996_msdu_page_get_from_cache-remove-null-ptr-check-v1-1-fbeb7881e192@kernel.org
Signed-off-by: Felix Fietkau <nbd@nbd.name>
drivers/net/wireless/mediatek/mt76/mt7996/mac.c

index fd3fabc60026954e344c5f59c1c585c4b2d445e0..ace23fd67c8d1f4e5be4356879ba4e81390b5bc6 100644 (file)
@@ -1681,8 +1681,7 @@ mt7996_msdu_page_get_from_cache(struct mt7996_dev *dev)
        if (!list_empty(&dev->wed_rro.page_cache)) {
                p = list_first_entry(&dev->wed_rro.page_cache,
                                     struct mt7996_msdu_page, list);
-               if (p)
-                       list_del(&p->list);
+               list_del(&p->list);
        }
 
        spin_unlock(&dev->wed_rro.lock);