]> git.ipfire.org Git - thirdparty/bootstrap.git/commitdiff
Improve build/generate-sri.js regex (#29753)
authorNoah Rosenzweig <rosenzweig.noah@gmail.com>
Sat, 21 Nov 2020 19:39:33 +0000 (20:39 +0100)
committerGitHub <noreply@github.com>
Sat, 21 Nov 2020 19:39:33 +0000 (21:39 +0200)
When using single-quotes in config.yml, the previous
regular expression in build/generate-cli.js wasn't working correctly,
it was replacing ALL string values with hashes.
Now both double- and single-quotes can be used in config.yml,
and the RegExp will work as expected.

Also, allow trailing whitespaces and empty ("") values to be matched.

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
build/generate-sri.js

index cfbf3777161e55f7e989ce7409820cd1792e5325..de269b0405e61e7f0dd91e9c88dfb47bfc83df60 100644 (file)
@@ -55,6 +55,6 @@ files.forEach(file => {
 
     console.log(`${file.configPropertyName}: ${integrity}`)
 
-    sh.sed('-i', new RegExp(`(\\s${file.configPropertyName}:\\s+"|')(\\S+)("|')`), `$1${integrity}$3`, configFile)
+    sh.sed('-i', new RegExp(`^(\\s+${file.configPropertyName}:\\s+["'])\\S*(["'])`), `$1${integrity}$2`, configFile)
   })
 })