]> git.ipfire.org Git - thirdparty/knot-resolver.git/commitdiff
validator nitpick: remove a useless dead store
authorVladimír Čunát <vladimir.cunat@nic.cz>
Mon, 15 Jan 2018 17:08:47 +0000 (18:08 +0100)
committerVladimír Čunát <vladimir.cunat@nic.cz>
Mon, 22 Jan 2018 10:18:02 +0000 (11:18 +0100)
Discovered by clang scan.

lib/dnssec/nsec3.c

index da5539cfcd260c044fd76672a3eb04594b286779..898eaec8cc90834767831e0ef75ee0a12080fc35 100644 (file)
@@ -677,7 +677,6 @@ int kr_nsec3_no_data(const knot_pkt_t *pkt, knot_section_t section_id,
 
 int kr_nsec3_ref_to_unsigned(const knot_pkt_t *pkt)
 {
-       int ret = kr_error(EINVAL);
        int flags = 0;
        uint8_t *bm = NULL;
        uint16_t bm_size = 0;
@@ -739,8 +738,8 @@ int kr_nsec3_ref_to_unsigned(const knot_pkt_t *pkt)
                 */
                const knot_dname_t *encloser_name = NULL;
                const knot_rrset_t *covering_next_nsec3 = NULL;
-               ret = closest_encloser_proof(pkt, KNOT_AUTHORITY, ns->owner, &encloser_name,
-                                     NULL, &covering_next_nsec3);
+               int ret = closest_encloser_proof(pkt, KNOT_AUTHORITY, ns->owner,
+                               &encloser_name, NULL, &covering_next_nsec3);
                if (ret != 0) {
                        return kr_error(EINVAL);
                }