]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
tools/mm/page_owner_sort: fix timestamp comparison for stable sorting
authorKaushlendra Kumar <kaushlendra.kumar@intel.com>
Tue, 9 Dec 2025 04:45:52 +0000 (10:15 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 8 Jan 2026 09:14:50 +0000 (10:14 +0100)
commit 7013803444dd3bbbe28fd3360c084cec3057c554 upstream.

The ternary operator in compare_ts() returns 1 when timestamps are equal,
causing unstable sorting behavior. Replace with explicit three-way
comparison that returns 0 for equal timestamps, ensuring stable qsort
ordering and consistent output.

Link: https://lkml.kernel.org/r/20251209044552.3396468-1-kaushlendra.kumar@intel.com
Fixes: 8f9c447e2e2b ("tools/vm/page_owner_sort.c: support sorting pid and time")
Signed-off-by: Kaushlendra Kumar <kaushlendra.kumar@intel.com>
Cc: Chongxi Zhao <zhaochongxi2019@email.szu.edu.cn>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
tools/mm/page_owner_sort.c

index e1f264444342975f535a3954f05d0a018d97c1e8..42bad1324501c65a0fb14b96ba1e0f703ad2812f 100644 (file)
@@ -183,7 +183,11 @@ static int compare_ts(const void *p1, const void *p2)
 {
        const struct block_list *l1 = p1, *l2 = p2;
 
-       return l1->ts_nsec < l2->ts_nsec ? -1 : 1;
+       if (l1->ts_nsec < l2->ts_nsec)
+               return -1;
+       if (l1->ts_nsec > l2->ts_nsec)
+               return 1;
+       return 0;
 }
 
 static int compare_cull_condition(const void *p1, const void *p2)