]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ratelimit: Don't flush misses counter if RATELIMIT_MSG_ON_RELEASE
authorPaul E. McKenney <paulmck@kernel.org>
Thu, 10 Apr 2025 21:37:31 +0000 (14:37 -0700)
committerPaul E. McKenney <paulmck@kernel.org>
Thu, 8 May 2025 23:13:27 +0000 (16:13 -0700)
Restore the previous semantics where the misses counter is unchanged if
the RATELIMIT_MSG_ON_RELEASE flag is set.

Link: https://lore.kernel.org/all/fbe93a52-365e-47fe-93a4-44a44547d601@paulmck-laptop/
Link: https://lore.kernel.org/all/20250423115409.3425-1-spasswolf@web.de/
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Reviewed-by: Petr Mladek <pmladek@suse.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Kuniyuki Iwashima <kuniyu@amazon.com>
Cc: Mateusz Guzik <mjguzik@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: John Ogness <john.ogness@linutronix.de>
Cc: Sergey Senozhatsky <senozhatsky@chromium.org>
lib/ratelimit.c

index 7d4f4e241213e55c2fa123fdb24a849b1664e718..4e520d029d28f08feb621fbc96409a2d7c590362 100644 (file)
@@ -92,9 +92,9 @@ int ___ratelimit(struct ratelimit_state *rs, const char *func)
                atomic_set(&rs->rs_n_left, rs->burst);
                rs->begin = jiffies;
 
-               m = ratelimit_state_reset_miss(rs);
-               if (m) {
-                       if (!(rs->flags & RATELIMIT_MSG_ON_RELEASE)) {
+               if (!(rs->flags & RATELIMIT_MSG_ON_RELEASE)) {
+                       m = ratelimit_state_reset_miss(rs);
+                       if (m) {
                                printk_deferred(KERN_WARNING
                                                "%s: %d callbacks suppressed\n", func, m);
                        }