metrics: Decrement hs_intro_established_count on intro circuit close.

Closes #40751.

Signed-off-by: Gabriela Moldovan <gabi@torproject.org>

diff --git a/changes/bug40751 b/changes/bug40751
new file mode 100644 (file)
index 0000000..baa5e90
--- /dev/null
+++ b/changes/bug40751
@@ -0,0 +1,3 @@
+  o Minor bugfixes (metrics):
+    - Decrement hs_intro_established_count on introduction circuit close. Fixes
+      bug 40751; bugfix on 0.4.7.12.

diff --git a/src/feature/hs/hs_metrics.h b/src/feature/hs/hs_metrics.h
index 6af3a7e7f073fd80a34d026511d4d50c9401cfb7..2e0fa5048ddfcb84ee1dcbed0db65f63f0a90a5d 100644 (file)
--- a/src/feature/hs/hs_metrics.h
+++ b/src/feature/hs/hs_metrics.h
@@ -65,6 +65,6 @@ void hs_metrics_update_by_service(const hs_metrics_key_t key,
 /** Established introduction circuit closes. This is called when
  * INTRO_ESTABLISHED circuit is marked for close. */
 #define hs_metrics_close_established_intro(i) \
-  hs_metrics_update_by_ident(HS_METRICS_NUM_ESTABLISHED_INTRO, (i), 0, 1)
+  hs_metrics_update_by_ident(HS_METRICS_NUM_ESTABLISHED_INTRO, (i), 0, -1)
 
 #endif /* !defined(TOR_FEATURE_HS_HS_METRICS_H) */