]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
can: janz-ican3: use sysfs_emit() in fwinfo_show()
authorKhaled Elnaggar <khaledelnaggarlinux@gmail.com>
Sat, 12 Jul 2025 13:36:07 +0000 (16:36 +0300)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Tue, 15 Jul 2025 09:41:41 +0000 (11:41 +0200)
As recommended in Documentation/filesystems/sysfs.rst, show() callbacks
should use sysfs_emit() or sysfs_emit_at() to format values returned to
userspace. Replace scnprintf() with sysfs_emit() in fwinfo_show().

Signed-off-by: Khaled Elnaggar <khaledelnaggarlinux@gmail.com>
Link: https://patch.msgid.link/20250712133609.331904-1-khaledelnaggarlinux@gmail.com
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
drivers/net/can/janz-ican3.c

index 60c7b83b4539e1f83dfdc932997b9075a051bfd6..bfa5cbe88017d42a61caa20d22e25084f1a9656a 100644 (file)
@@ -1867,7 +1867,7 @@ static ssize_t fwinfo_show(struct device *dev,
 {
        struct ican3_dev *mod = netdev_priv(to_net_dev(dev));
 
-       return scnprintf(buf, PAGE_SIZE, "%s\n", mod->fwinfo);
+       return sysfs_emit(buf, "%s\n", mod->fwinfo);
 }
 
 static DEVICE_ATTR_RW(termination);