]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
vboxDumpNetwork: use a switch for attachmentType
authorJán Tomko <jtomko@redhat.com>
Fri, 23 Feb 2018 13:41:03 +0000 (14:41 +0100)
committerJán Tomko <jtomko@redhat.com>
Mon, 5 Mar 2018 11:57:47 +0000 (12:57 +0100)
Signed-off-by: Ján Tomko <jtomko@redhat.com>
src/vbox/vbox_common.c

index 2943c534df12a0bf5feab727e947a2c089094f03..8f5f04efb30f088e9383095bd5317fc6c6dd08d1 100644 (file)
@@ -3707,11 +3707,13 @@ vboxDumpNetwork(vboxDriverPtr data, INetworkAdapter *adapter)
         return NULL;
 
     gVBoxAPI.UINetworkAdapter.GetAttachmentType(adapter, &attachmentType);
-    if (attachmentType == NetworkAttachmentType_NAT) {
 
+    switch (attachmentType) {
+    case NetworkAttachmentType_NAT:
         net->type = VIR_DOMAIN_NET_TYPE_USER;
+        break;
 
-    } else if (attachmentType == NetworkAttachmentType_Bridged) {
+    case NetworkAttachmentType_Bridged:
         net->type = VIR_DOMAIN_NET_TYPE_BRIDGE;
 
         gVBoxAPI.UINetworkAdapter.GetBridgedInterface(adapter, &utf16);
@@ -3721,8 +3723,9 @@ vboxDumpNetwork(vboxDriverPtr data, INetworkAdapter *adapter)
 
         VBOX_UTF8_FREE(utf8);
         VBOX_UTF16_FREE(utf16);
+        break;
 
-    } else if (attachmentType == NetworkAttachmentType_Internal) {
+    case NetworkAttachmentType_Internal:
         net->type = VIR_DOMAIN_NET_TYPE_INTERNAL;
 
         gVBoxAPI.UINetworkAdapter.GetInternalNetwork(adapter, &utf16);
@@ -3732,8 +3735,9 @@ vboxDumpNetwork(vboxDriverPtr data, INetworkAdapter *adapter)
 
         VBOX_UTF8_FREE(utf8);
         VBOX_UTF16_FREE(utf16);
+        break;
 
-    } else if (attachmentType == NetworkAttachmentType_HostOnly) {
+    case NetworkAttachmentType_HostOnly:
         net->type = VIR_DOMAIN_NET_TYPE_NETWORK;
 
         gVBoxAPI.UINetworkAdapter.GetHostOnlyInterface(adapter, &utf16);
@@ -3743,8 +3747,9 @@ vboxDumpNetwork(vboxDriverPtr data, INetworkAdapter *adapter)
 
         VBOX_UTF8_FREE(utf8);
         VBOX_UTF16_FREE(utf16);
+        break;
 
-    } else {
+    default:
         /* default to user type i.e. NAT in VirtualBox if this
          * dump is ever used to create a machine.
          */