fs: PM: Fix reverse check in filesystems_freeze_callback()

The freeze_all_ptr check in filesystems_freeze_callback() introduced by
commit a3f8f8662771 ("power: always freeze efivarfs") is reverse which
quite confusingly causes all file systems to be frozen when
filesystem_freeze_enabled is false.

On my systems it causes the WARN_ON_ONCE() in __set_task_frozen() to
trigger, most likely due to an attempt to freeze a file system that is
not ready for that.

Add a logical negation to the check in question to reverse it as
appropriate.

Fixes: a3f8f8662771 ("power: always freeze efivarfs")
Cc: 6.18+ <stable@vger.kernel.org> # 6.18+
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Link: https://patch.msgid.link/12788397.O9o76ZdvQC@rafael.j.wysocki
Signed-off-by: Christian Brauner <brauner@kernel.org>

diff --git a/fs/super.c b/fs/super.c
index 7c66b96b59be90cd92d35ce63576b36141f91869..9197e0ba54dd5b57002848c8f4e9db95d2355978 100644 (file)
--- a/fs/super.c
+++ b/fs/super.c
@@ -1189,7 +1189,7 @@ static void filesystems_freeze_callback(struct super_block *sb, void *freeze_all
        if (!sb->s_op->freeze_fs && !sb->s_op->freeze_super)
                return;
 
-       if (freeze_all_ptr && !(sb->s_type->fs_flags & FS_POWER_FREEZE))
+       if (!freeze_all_ptr && !(sb->s_type->fs_flags & FS_POWER_FREEZE))
                return;
 
        if (!get_active_super(sb))