]> git.ipfire.org Git - thirdparty/hostap.git/commitdiff
DPP: Verify that crypto_ec_point_to_bin() succeeds
authorJouni Malinen <j@w1.fi>
Sat, 7 May 2022 21:31:25 +0000 (00:31 +0300)
committerJouni Malinen <j@w1.fi>
Sat, 7 May 2022 21:31:25 +0000 (00:31 +0300)
This is testing code, but it's better to check the return value
explicitly even if this were not really able to fail in practice.

Signed-off-by: Jouni Malinen <j@w1.fi>
src/common/dpp_crypto.c

index 47f56c258b69a9361e986622d9fd63154400926d..8d3f3abfa6ae76415df81a3da5633b2a7d1ae069 100644 (file)
@@ -2472,11 +2472,9 @@ retry:
 
        /* Retrieve public key coordinates */
        pub_key = crypto_ec_key_get_public_key(key);
-       if (!pub_key)
+       if (!pub_key || crypto_ec_point_to_bin(ec, pub_key, x, y))
                goto fail;
 
-       crypto_ec_point_to_bin(ec, pub_key, x, y);
-
        /* And corrupt them */
        y[curve->prime_len - 1] ^= 0x01;
        p = crypto_ec_point_from_bin(ec, x);