]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
usb: dwc3-am62: Fix an OF node leak in phy_syscon_pll_refclk()
authorJoe Hattori <joe@pf.is.s.u-tokyo.ac.jp>
Thu, 9 Jan 2025 00:16:38 +0000 (09:16 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 8 Feb 2025 09:02:22 +0000 (10:02 +0100)
commit a266462b937beba065e934a563efe13dd246a164 upstream.

phy_syscon_pll_refclk() leaks an OF node obtained by
of_parse_phandle_with_fixed_args(), thus add an of_node_put() call.

Cc: stable <stable@kernel.org>
Fixes: e8784c0aec03 ("drivers: usb: dwc3: Add AM62 USB wrapper driver")
Signed-off-by: Joe Hattori <joe@pf.is.s.u-tokyo.ac.jp>
Acked-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Link: https://lore.kernel.org/r/20250109001638.70033-1-joe@pf.is.s.u-tokyo.ac.jp
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/dwc3/dwc3-am62.c

index 7d43da5f28973d601664c67c0a0d73b7e8fd1cce..d102506f94713ae510600e17dc3eacd0ad6d0b60 100644 (file)
@@ -166,6 +166,7 @@ static int phy_syscon_pll_refclk(struct dwc3_am62 *am62)
        if (ret)
                return ret;
 
+       of_node_put(args.np);
        am62->offset = args.args[0];
 
        /* Core voltage. PHY_CORE_VOLTAGE bit Recommended to be 0 always */