- Fix seed for random backup code to use explicit zero when wiped.

git-svn-id: file:///svn/unbound/trunk@4895 be551aaa-1e26-0410-a405-d3ace91eadb9

diff --git a/daemon/worker.c b/daemon/worker.c
index a23c4994bee4d1c3824548f20c5cb73bb2415dda..2697ea6534f12998e5622529ae80bf37875f867b 100644 (file)
--- a/daemon/worker.c
+++ b/daemon/worker.c
@@ -1671,14 +1671,14 @@ worker_create(struct daemon* daemon, int id, int* ports, int n)
                (((unsigned int)worker->thread_num)<<17);
                /* shift thread_num so it does not match out pid bits */
        if(!(worker->rndstate = ub_initstate(seed, daemon->rand))) {
-               seed = 0;
+               explicit_bzero(&seed, sizeof(seed));
                log_err("could not init random numbers.");
                tube_delete(worker->cmd);
                free(worker->ports);
                free(worker);
                return NULL;
        }
-       seed = 0;
+       explicit_bzero(&seed, sizeof(seed));
 #ifdef USE_DNSTAP
        if(daemon->cfg->dnstap) {
                log_assert(daemon->dtenv != NULL);

diff --git a/doc/Changelog b/doc/Changelog
index 1a695bc35edd34cfa66f822bcb8639d9232f0f35..38efef4ad9f56657859d60d1e677b15c997726f4 100644 (file)
--- a/doc/Changelog
+++ b/doc/Changelog
@@ -1,3 +1,6 @@
+13 September 2018: Wouter
+       - Fix seed for random backup code to use explicit zero when wiped.
+
 11 September 2018: Wouter
        - Fixed unused return value warnings in contrib/fastrpz.patch for
          asprintf.