[#1733] Addressed more comments

A few more cosmetic fixes.

diff --git a/src/hooks/dhcp/high_availability/ha_impl.cc b/src/hooks/dhcp/high_availability/ha_impl.cc
index 9ca69f07127c741302015297977f1afa8009b1ae..b2e3d55b26f835accc3d2b99f0b7bea1d4b07dca 100644 (file)
--- a/src/hooks/dhcp/high_availability/ha_impl.cc
+++ b/src/hooks/dhcp/high_availability/ha_impl.cc
@@ -147,7 +147,7 @@ HAImpl::leases4Committed(CalloutHandle& callout_handle) {
             // Dereference the parked packet.  This releases our stake in it.
             parking_lot->dereference(query4);
             return;
-        } 
+        }
     } catch (...) {
         // Make sure we dereference.
         parking_lot->dereference(query4);
@@ -261,7 +261,7 @@ HAImpl::leases6Committed(CalloutHandle& callout_handle) {
             // Dereference the parked packet.  This releases our stake in it.
             parking_lot->dereference(query6);
             return;
-        } 
+        }
     } catch (...) {
         // Make sure we dereference.
         parking_lot->dereference(query6);

diff --git a/src/hooks/dhcp/high_availability/tests/ha_impl_unittest.cc b/src/hooks/dhcp/high_availability/tests/ha_impl_unittest.cc
index e54272cac4a0b630e0a1cb9114a265eb00a2d973..6282e7749e41f805b3cd4692c933f1f7810b004d 100644 (file)
--- a/src/hooks/dhcp/high_availability/tests/ha_impl_unittest.cc
+++ b/src/hooks/dhcp/high_availability/tests/ha_impl_unittest.cc
@@ -496,6 +496,7 @@ TEST_F(HAImplTest, leases6Committed) {
     // Park the packet.
     HooksManager::park("leases6_committed", query6, []{});
 
+    // Run the callout again.
     ASSERT_NO_THROW(ha_impl.leases6Committed(*callout_handle));
 
     // This time the lease update should be generated and the status should

diff --git a/src/lib/hooks/tests/parking_lots_unittest.cc b/src/lib/hooks/tests/parking_lots_unittest.cc
index c17f02a749fefead91ea8d98a2c5e8f89d8abe10..bba9417322e21101aa27cf0e8a9e77815308ec35 100644 (file)
--- a/src/lib/hooks/tests/parking_lots_unittest.cc
+++ b/src/lib/hooks/tests/parking_lots_unittest.cc
@@ -206,7 +206,7 @@ TEST(ParkingLotsTest, dereference) {
     StringPtr parked_object(new std::string("foo"));
 
     // Verify that an object that hasn't been parked, cannot be
-    // dererferenced.
+    // dereferenced.
     ASSERT_THROW(parking_lot_handle->dereference(parked_object),
                  InvalidOperation);