]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
9p: forgetting to cancel request on interrupted zero-copy RPC
authorAl Viro <viro@zeniv.linux.org.uk>
Sat, 4 Jul 2015 20:04:19 +0000 (16:04 -0400)
committerZefan Li <lizefan@huawei.com>
Thu, 22 Oct 2015 01:20:07 +0000 (09:20 +0800)
commit a84b69cb6e0a41e86bc593904faa6def3b957343 upstream.

If we'd already sent a request and decide to abort it, we *must*
issue TFLUSH properly and not just blindly reuse the tag, or
we'll get seriously screwed when response eventually arrives
and we confuse it for response to later request that had reused
the same tag.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Zefan Li <lizefan@huawei.com>
net/9p/client.c

index b23a17c431c87ae8ae3c000349ad52f048286bff..32df0a3de2772267d026328154f5d400ae2331ce 100644 (file)
@@ -833,7 +833,8 @@ static struct p9_req_t *p9_client_zc_rpc(struct p9_client *c, int8_t type,
        if (err < 0) {
                if (err == -EIO)
                        c->status = Disconnected;
-               goto reterr;
+               if (err != -ERESTARTSYS)
+                       goto reterr;
        }
        if (req->status == REQ_STATUS_ERROR) {
                p9_debug(P9_DEBUG_ERROR, "req_status error %d\n", req->t_err);