]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
scsi: ufs: ufs-pci: Remove control of UIC Completion interrupt for Intel MTL
authorAdrian Hunter <adrian.hunter@intel.com>
Wed, 23 Jul 2025 16:58:56 +0000 (19:58 +0300)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 25 Jul 2025 02:37:30 +0000 (22:37 -0400)
Now that UFS core enables the UIC Completion interrupt only when needed,
Intel MTL driver no longer needs to control the interrupt itself.  So
remove the associated code.

Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Link: https://lore.kernel.org/r/20250723165856.145750-9-adrian.hunter@intel.com
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/ufs/host/ufshcd-pci.c

index b29ec1904482a33b28f487c51c496689b0fffd45..b39239f641f21bd9bd69c629149c8547cae133c6 100644 (file)
@@ -211,32 +211,6 @@ out:
        return ret;
 }
 
-static void ufs_intel_ctrl_uic_compl(struct ufs_hba *hba, bool enable)
-{
-       u32 set = ufshcd_readl(hba, REG_INTERRUPT_ENABLE);
-
-       if (enable)
-               set |= UIC_COMMAND_COMPL;
-       else
-               set &= ~UIC_COMMAND_COMPL;
-       ufshcd_writel(hba, set, REG_INTERRUPT_ENABLE);
-}
-
-static void ufs_intel_mtl_h8_notify(struct ufs_hba *hba,
-                                   enum uic_cmd_dme cmd,
-                                   enum ufs_notify_change_status status)
-{
-       /*
-        * Disable UIC COMPL INTR to prevent access to UFSHCI after
-        * checking HCS.UPMCRS
-        */
-       if (status == PRE_CHANGE && cmd == UIC_CMD_DME_HIBER_ENTER)
-               ufs_intel_ctrl_uic_compl(hba, false);
-
-       if (status == POST_CHANGE && cmd == UIC_CMD_DME_HIBER_EXIT)
-               ufs_intel_ctrl_uic_compl(hba, true);
-}
-
 #define INTEL_ACTIVELTR                0x804
 #define INTEL_IDLELTR          0x808
 
@@ -549,7 +523,6 @@ static struct ufs_hba_variant_ops ufs_intel_mtl_hba_vops = {
        .init                   = ufs_intel_mtl_init,
        .exit                   = ufs_intel_common_exit,
        .hce_enable_notify      = ufs_intel_hce_enable_notify,
-       .hibern8_notify         = ufs_intel_mtl_h8_notify,
        .link_startup_notify    = ufs_intel_link_startup_notify,
        .resume                 = ufs_intel_resume,
        .device_reset           = ufs_intel_device_reset,