]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
gpio: tps65912: use new GPIO line value setter callbacks
authorBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Mon, 7 Jul 2025 07:50:16 +0000 (09:50 +0200)
committerBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Sun, 13 Jul 2025 08:45:04 +0000 (10:45 +0200)
struct gpio_chip now has callbacks for setting line values that return
an integer, allowing to indicate failures. Convert the driver to using
them.

Link: https://lore.kernel.org/r/20250707-gpiochip-set-rv-gpio-round4-v1-3-35668aaaf6d2@linaro.org
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
drivers/gpio/gpio-tps65912.c

index bac757c191c2ea0d103eb0577710065611fd79aa..d586ccfbfc56c17ca18f5c2b04a807305dd66890 100644 (file)
@@ -76,13 +76,13 @@ static int tps65912_gpio_get(struct gpio_chip *gc, unsigned offset)
        return 0;
 }
 
-static void tps65912_gpio_set(struct gpio_chip *gc, unsigned offset,
-                             int value)
+static int tps65912_gpio_set(struct gpio_chip *gc, unsigned int offset,
+                            int value)
 {
        struct tps65912_gpio *gpio = gpiochip_get_data(gc);
 
-       regmap_update_bits(gpio->tps->regmap, TPS65912_GPIO1 + offset,
-                          GPIO_SET_MASK, value ? GPIO_SET_MASK : 0);
+       return regmap_update_bits(gpio->tps->regmap, TPS65912_GPIO1 + offset,
+                                 GPIO_SET_MASK, value ? GPIO_SET_MASK : 0);
 }
 
 static const struct gpio_chip template_chip = {
@@ -92,7 +92,7 @@ static const struct gpio_chip template_chip = {
        .direction_input        = tps65912_gpio_direction_input,
        .direction_output       = tps65912_gpio_direction_output,
        .get                    = tps65912_gpio_get,
-       .set                    = tps65912_gpio_set,
+       .set_rv                 = tps65912_gpio_set,
        .base                   = -1,
        .ngpio                  = 5,
        .can_sleep              = true,