]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
clk: at91: keep securam node alive while mapping it
authorYuho Choi <dbgh9129@gmail.com>
Fri, 29 May 2026 04:20:51 +0000 (00:20 -0400)
committerClaudiu Beznea <claudiu.beznea@tuxon.dev>
Sun, 31 May 2026 14:17:55 +0000 (17:17 +0300)
pmc_register_ops() gets an owned reference to the
"atmel,sama5d2-securam" node with of_find_compatible_node().  The
success path dropped that reference before passing the node to
of_iomap(), leaving of_iomap() to consume a node pointer after the caller
had released its reference.

Move of_node_put() after of_iomap() so the node remains referenced for
the mapping operation.  The unavailable-node error path already releases
the reference.

Fixes: 4d21be864092 ("clk: at91: pmc: execute suspend/resume only for backup mode")
Signed-off-by: Yuho Choi <dbgh9129@gmail.com>
Reviewed-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Link: https://patch.msgid.link/20260529042051.1626978-1-dbgh9129@gmail.com
Signed-off-by: Claudiu Beznea <claudiu.beznea@tuxon.dev>
drivers/clk/at91/pmc.c

index b618a5e00b0068c19d9d77df922b73d961c15326..03a6c31d6aa8b54f313c48dde5aeeb64d1b7eb4e 100644 (file)
@@ -180,9 +180,9 @@ static int __init pmc_register_ops(void)
                of_node_put(np);
                return -ENODEV;
        }
-       of_node_put(np);
 
        at91_pmc_backup_suspend = of_iomap(np, 0);
+       of_node_put(np);
        if (!at91_pmc_backup_suspend) {
                pr_warn("%s(): unable to map securam\n", __func__);
                return -ENOMEM;