ceph: fix inode leak on getattr error in __fh_to_dentry

[ Upstream commit 1775c7ddacfcea29051c67409087578f8f4d751b ]

Fixes: 878dabb64117 ("ceph: don't return -ESTALE if there's still an open file")
Signed-off-by: Jeff Layton <jlayton@kernel.org>
Reviewed-by: Xiubo Li <xiubli@redhat.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/fs/ceph/export.c b/fs/ceph/export.c
index e088843a7734c03592adfe0ec962ed1c71d85a5a..baa6368bece59a5077ce1d343ac8b8e91b4e8fa4 100644 (file)
--- a/fs/ceph/export.c
+++ b/fs/ceph/export.c
@@ -178,8 +178,10 @@ static struct dentry *__fh_to_dentry(struct super_block *sb, u64 ino)
                return ERR_CAST(inode);
        /* We need LINK caps to reliably check i_nlink */
        err = ceph_do_getattr(inode, CEPH_CAP_LINK_SHARED, false);
-       if (err)
+       if (err) {
+               iput(inode);
                return ERR_PTR(err);
+       }
        /* -ESTALE if inode as been unlinked and no file is open */
        if ((inode->i_nlink == 0) && (atomic_read(&inode->i_count) == 1)) {
                iput(inode);