]> git.ipfire.org Git - thirdparty/kernel/stable-queue.git/commitdiff
5.10-stable patches
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 16 Jan 2023 14:49:29 +0000 (15:49 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 16 Jan 2023 14:49:29 +0000 (15:49 +0100)
added patches:
io_uring-io-wq-free-worker-if-task_work-creation-is-canceled.patch
io_uring-io-wq-only-free-worker-if-it-was-allocated-for-creation.patch

queue-5.10/io_uring-io-wq-free-worker-if-task_work-creation-is-canceled.patch [new file with mode: 0644]
queue-5.10/io_uring-io-wq-only-free-worker-if-it-was-allocated-for-creation.patch [new file with mode: 0644]
queue-5.10/series

diff --git a/queue-5.10/io_uring-io-wq-free-worker-if-task_work-creation-is-canceled.patch b/queue-5.10/io_uring-io-wq-free-worker-if-task_work-creation-is-canceled.patch
new file mode 100644 (file)
index 0000000..730e1a6
--- /dev/null
@@ -0,0 +1,34 @@
+From af82425c6a2d2f347c79b63ce74fca6dc6be157f Mon Sep 17 00:00:00 2001
+From: Jens Axboe <axboe@kernel.dk>
+Date: Mon, 2 Jan 2023 16:49:46 -0700
+Subject: io_uring/io-wq: free worker if task_work creation is canceled
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+From: Jens Axboe <axboe@kernel.dk>
+
+commit af82425c6a2d2f347c79b63ce74fca6dc6be157f upstream.
+
+If we cancel the task_work, the worker will never come into existance.
+As this is the last reference to it, ensure that we get it freed
+appropriately.
+
+Cc: stable@vger.kernel.org
+Reported-by: 진호 <wnwlsgh98@gmail.com>
+Signed-off-by: Jens Axboe <axboe@kernel.dk>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ io_uring/io-wq.c |    1 +
+ 1 file changed, 1 insertion(+)
+
+--- a/io_uring/io-wq.c
++++ b/io_uring/io-wq.c
+@@ -1217,6 +1217,7 @@ static void io_wq_cancel_tw_create(struc
+               worker = container_of(cb, struct io_worker, create_work);
+               io_worker_cancel_cb(worker);
++              kfree(worker);
+       }
+ }
diff --git a/queue-5.10/io_uring-io-wq-only-free-worker-if-it-was-allocated-for-creation.patch b/queue-5.10/io_uring-io-wq-only-free-worker-if-it-was-allocated-for-creation.patch
new file mode 100644 (file)
index 0000000..e3983a8
--- /dev/null
@@ -0,0 +1,38 @@
+From e6db6f9398dadcbc06318a133d4c44a2d3844e61 Mon Sep 17 00:00:00 2001
+From: Jens Axboe <axboe@kernel.dk>
+Date: Sun, 8 Jan 2023 10:39:17 -0700
+Subject: io_uring/io-wq: only free worker if it was allocated for creation
+
+From: Jens Axboe <axboe@kernel.dk>
+
+commit e6db6f9398dadcbc06318a133d4c44a2d3844e61 upstream.
+
+We have two types of task_work based creation, one is using an existing
+worker to setup a new one (eg when going to sleep and we have no free
+workers), and the other is allocating a new worker. Only the latter
+should be freed when we cancel task_work creation for a new worker.
+
+Fixes: af82425c6a2d ("io_uring/io-wq: free worker if task_work creation is canceled")
+Reported-by: syzbot+d56ec896af3637bdb7e4@syzkaller.appspotmail.com
+Signed-off-by: Jens Axboe <axboe@kernel.dk>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ io_uring/io-wq.c |    7 ++++++-
+ 1 file changed, 6 insertions(+), 1 deletion(-)
+
+--- a/io_uring/io-wq.c
++++ b/io_uring/io-wq.c
+@@ -1217,7 +1217,12 @@ static void io_wq_cancel_tw_create(struc
+               worker = container_of(cb, struct io_worker, create_work);
+               io_worker_cancel_cb(worker);
+-              kfree(worker);
++              /*
++               * Only the worker continuation helper has worker allocated and
++               * hence needs freeing.
++               */
++              if (cb->func == create_worker_cont)
++                      kfree(worker);
+       }
+ }
index f9c59c49a48e2b56d4279d1eaf6d32004ebfee80..e6fe98c5095e09a4923780938190f5f35c3c67d9 100644 (file)
@@ -59,3 +59,5 @@ arm64-atomics-remove-ll-sc-trampolines.patch
 arm64-cmpxchg_double-hazard-against-entire-exchange-.patch
 efi-fix-null-deref-in-init-error-path.patch
 drm-virtio-fix-gem-handle-creation-uaf.patch
+io_uring-io-wq-free-worker-if-task_work-creation-is-canceled.patch
+io_uring-io-wq-only-free-worker-if-it-was-allocated-for-creation.patch