]> git.ipfire.org Git - thirdparty/vim.git/commitdiff
runtime(netrw): do not double escape Vim special characters
authorKonfekt <Konfekt@users.noreply.github.com>
Fri, 20 Dec 2024 18:41:02 +0000 (19:41 +0100)
committerChristian Brabandt <cb@256bit.org>
Fri, 20 Dec 2024 18:41:02 +0000 (19:41 +0100)
This double escaping was likely introduced because it was the only way
to make :Open work with hashes/percent signs despite shellescape(..., 1)
supposedly taking care of it, but then breaks the gx mapping
on MSYS2 as reported at [0]

Since special characters in the URL following :Open can be escaped,
whereas gx simply breaks and is more common, no longer double escape

[0]: https://github.com/vim/vim/issues/16252

fixes: #16252
closes: #16265

Signed-off-by: Konfekt <Konfekt@users.noreply.github.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
runtime/autoload/netrw.vim

index c6af6ca4ba1d00fb989ebc80a461a0f73d344f89..96cfdb6001c1f74348afc466e7ab3a672bee317c 100644 (file)
@@ -5200,8 +5200,7 @@ fun! netrw#BrowseX(fname,remote)
     endif
   endif
 
-  " although shellescape(..., 1) is used in netrw#Open(), it's insufficient
-  call netrw#Open(escape(fname, '#%'))
+  call netrw#Open(fname)
 
   " cleanup: remove temporary file,
   "          delete current buffer if success with handler,