fix(pool): make sure to throw a RuntimeError opening async pool without a loop

The error would be thrown anyway downstream, when tasks are created, but
other spurious warning might be raised too because certain tasks are not
awaited.

diff --git a/psycopg_pool/psycopg_pool/pool_async.py b/psycopg_pool/psycopg_pool/pool_async.py
index b7bb52a58fe7bfcfb159eb7179cb92bc0036c236..d411d8bc091a5f783925fe33aaf7bd2273338787 100644 (file)
--- a/psycopg_pool/psycopg_pool/pool_async.py
+++ b/psycopg_pool/psycopg_pool/pool_async.py
@@ -204,6 +204,9 @@ class AsyncConnectionPool(BasePool[AsyncConnection[Any]]):
         if not self._closed:
             return
 
+        # Throw a RuntimeError if the pool is open outside a running loop.
+        asyncio.get_running_loop()
+
         self._check_open()
 
         # Create these objects now to attach them to the right loop.

diff --git a/tests/pool/test_pool_async_noasyncio.py b/tests/pool/test_pool_async_noasyncio.py
index 56cd50b81f0663261a9d0011e09ca61582797f7f..0f0813716b18a953074c6a8819d1a0c8900163e2 100644 (file)
--- a/tests/pool/test_pool_async_noasyncio.py
+++ b/tests/pool/test_pool_async_noasyncio.py
@@ -51,3 +51,8 @@ def test_working_created_before_loop(dsn):
             await p.close()
 
     asyncio.run(asyncio.wait_for(test(), timeout=2.0))
+
+
+def test_cant_create_open_outside_loop(dsn):
+    with pytest.raises(RuntimeError):
+        pool.AsyncConnectionPool(dsn, open=True)