]> git.ipfire.org Git - thirdparty/util-linux.git/commitdiff
libsmartcols: use snprintf() rather than sprintf()
authorKarel Zak <kzak@redhat.com>
Tue, 27 Jul 2021 11:28:52 +0000 (13:28 +0200)
committerKarel Zak <kzak@redhat.com>
Tue, 27 Jul 2021 11:28:52 +0000 (13:28 +0200)
libsmartcols/samples/continuous.c

index fe3a8752cbed0f8f59874f2738c097c16e7fb86a..7db3f8464d810b76041f600823107f24ffac6b90 100644 (file)
@@ -69,6 +69,7 @@ int main(int argc, char *argv[])
 {
        struct libscols_table *tb;
        size_t i;
+       const size_t timecellsz = sizeof(stringify_value(UINT_MAX));
        struct timeval last;
 
        scols_init_debug(0);
@@ -84,7 +85,7 @@ int main(int argc, char *argv[])
                struct libscols_line *line;
                struct timeval now;
                int done = 0;
-               char *timecell = xmalloc( sizeof(stringify_value(UINT_MAX)) );
+               char *timecell = xmalloc( timecellsz );
 
                line = add_line(tb, i);
 
@@ -106,7 +107,7 @@ int main(int argc, char *argv[])
                                xusleep(100000);
 
                        /* update "TIME" cell data */
-                       sprintf(timecell, "%f [%3d%%]", diff,
+                       snprintf(timecell, timecellsz, "%f [%3d%%]", diff,
                                done ? 100 : (int)(diff / (TIME_PERIOD / 100.0)));
 
                        /* Note that libsmartcols don't print \n for last line