Bug 347707: Changing parameters could silently fail because we weren't correctly

 checking the return code from "rename"
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=justdave, a=mkanat

diff --git a/Bugzilla/Config.pm b/Bugzilla/Config.pm
index 3ee7da2fce7f4698b2fecd97f991d27b25bdf076..ba44f58a586a1f945d70e9c25eabd7224de4efe4 100644 (file)
--- a/Bugzilla/Config.pm
+++ b/Bugzilla/Config.pm
@@ -319,7 +319,7 @@ sub WriteParams {
     close $fh;
 
     rename $tmpname, "$datadir/params"
-      || die "Can't rename $tmpname to $datadir/params: $!";
+      or die "Can't rename $tmpname to $datadir/params: $!";
 
     ChmodDataFile("$datadir/params", 0666);
 }