]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
remoteproc: k3-m4: Don't assert reset in detach routine
authorBeleswar Padhi <b-padhi@ti.com>
Tue, 13 May 2025 05:44:38 +0000 (11:14 +0530)
committerMathieu Poirier <mathieu.poirier@linaro.org>
Tue, 20 May 2025 17:18:25 +0000 (11:18 -0600)
The rproc_detach() function invokes __rproc_detach() before
rproc_unprepare_device(). The __rproc_detach() function sets the
rproc->state to "RPROC_DETACHED".

However, the TI K3 M4 driver erroneously looks for "RPROC_ATTACHED"
state in its .unprepare ops to identify IPC-only mode; which leads to
resetting the rproc in detach routine.

Therefore, correct the IPC-only mode detection logic to look for
"RPROC_DETACHED" in k3_m4_rproc_unprepare() function.

Fixes: ebcf9008a895 ("remoteproc: k3-m4: Add a remoteproc driver for M4F subsystem")
Signed-off-by: Beleswar Padhi <b-padhi@ti.com>
Reviewed-by: Hari Nagalla <hnagalla@ti.com>
Reviewed-by: Martyn Welch <martyn.welch@collabora.com>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20250513054510.3439842-5-b-padhi@ti.com
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
drivers/remoteproc/ti_k3_m4_remoteproc.c

index a16fb165fcedd4fe11a607b095fe2eeaff4d630f..6cd50b16a8e82a23e762983206b99e995526c934 100644 (file)
@@ -228,7 +228,7 @@ static int k3_m4_rproc_unprepare(struct rproc *rproc)
        int ret;
 
        /* If the core is going to be detached do not assert the module reset */
-       if (rproc->state == RPROC_ATTACHED)
+       if (rproc->state == RPROC_DETACHED)
                return 0;
 
        ret = kproc->ti_sci->ops.dev_ops.put_device(kproc->ti_sci,