semcheck: CDNSKEY doesn't have to have SEP flag

diff --git a/src/knot/zone/semantic-check.c b/src/knot/zone/semantic-check.c
index 8ea6601322aa1be0b43c62740b449e4936705902..5b3462969931dc63ec8b03f8a00d57dbd1c3bd66 100644 (file)
--- a/src/knot/zone/semantic-check.c
+++ b/src/knot/zone/semantic-check.c
@@ -122,8 +122,6 @@ static const char *error_messages[SEM_ERR_UNKNOWN + 1] = {
        "missing CDNSKEY",
        [SEM_ERR_CDNSKEY_MULTIPLE] =
        "multiple CDNSKEY records",
-       [SEM_ERR_CDNSKEY_NOT_KSK] =
-       "CDNSKEY not match KSK DNSKEY",
        [SEM_ERR_CDNSKEY_NO_DNSKEY] =
        "CDNSKEY not match DNSKEY",
 
@@ -545,7 +543,6 @@ static int check_submission(const zone_node_t *node, semchecks_data_t *data)
                        return ret;
                }
 
-               uint16_t flags = dnssec_key_get_flags(key);
                dnssec_binary_t cds_calc = { 0 };
                dnssec_binary_t cds_orig = { .size = cds->len, .data = cds->data };
                ret = dnssec_key_create_ds(key, digest_type, &cds_calc);
@@ -558,13 +555,7 @@ static int check_submission(const zone_node_t *node, semchecks_data_t *data)
                dnssec_binary_free(&cds_calc);
                dnssec_key_free(key);
                if (ret == 0) {
-                       if (!(flags & DNSKEY_FLAGS_KSK)) {
-                               data->handler->cb(data->handler, data->zone,
-                                                 node, SEM_ERR_CDNSKEY_NOT_KSK,
-                                                 NULL);
-                       } else {
-                               return KNOT_EOK;
-                       }
+                       return KNOT_EOK;
                } else {
                        data->handler->cb(data->handler, data->zone, node,
                                          SEM_ERR_CDS_NOT_MATCH, NULL);

diff --git a/src/knot/zone/semantic-check.h b/src/knot/zone/semantic-check.h
index 7a3c4832d1f228f86f97cbb796bd3dbb45f18d7e..2010ec979ffc962b4d0ad109ab1720373232b35b 100644 (file)
--- a/src/knot/zone/semantic-check.h
+++ b/src/knot/zone/semantic-check.h
@@ -78,7 +78,6 @@ typedef enum {
 
        SEM_ERR_CDNSKEY_NONE,
        SEM_ERR_CDNSKEY_MULTIPLE,
-       SEM_ERR_CDNSKEY_NOT_KSK,
        SEM_ERR_CDNSKEY_NO_DNSKEY,
 
        // General error!