coverity: #1427191

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

diff --git a/src/lxc/conf.c b/src/lxc/conf.c
index f5bcb9d2411900388f1f693a1eb9fd275ff0ae52..d08cfad8e30e8923050cc8909ddcb4cfcb3ad125 100644 (file)
--- a/src/lxc/conf.c
+++ b/src/lxc/conf.c
@@ -2657,15 +2657,17 @@ int write_id_mapping(enum idtype idtype, pid_t pid, const char *buf,
                        return -1;
                }
 
-               buflen = sizeof("deny\n") - 1;
-               errno = 0;
-               ret = lxc_write_nointr(fd, "deny\n", buflen);
-               if (ret != buflen) {
-                       SYSERROR("Failed to write \"deny\" to \"/proc/%d/setgroups\"", pid);
+               if (fd >= 0) {
+                       buflen = sizeof("deny\n") - 1;
+                       errno = 0;
+                       ret = lxc_write_nointr(fd, "deny\n", buflen);
+                       if (ret != buflen) {
+                               SYSERROR("Failed to write \"deny\" to \"/proc/%d/setgroups\"", pid);
+                               close(fd);
+                               return -1;
+                       }
                        close(fd);
-                       return -1;
                }
-               close(fd);
        }
 
        ret = snprintf(path, MAXPATHLEN, "/proc/%d/%cid_map", pid,