]> git.ipfire.org Git - thirdparty/psycopg.git/commitdiff
test: skip high fd number test on Windows
authorDaniele Varrazzo <daniele.varrazzo@gmail.com>
Tue, 1 Nov 2022 23:38:50 +0000 (00:38 +0100)
committerDaniele Varrazzo <daniele.varrazzo@gmail.com>
Sun, 11 Dec 2022 20:04:31 +0000 (20:04 +0000)
Windows is pretty simple in regards of the wait function, because it only
implement select, and it doesn't have the same limit of the Unix select.

However this test sometimes fails in weird ways: on the pgconn.socket >
1024 assert, for instance. So, let's just skip it.

tests/test_waiting.py

index e187af13acf446626dd06ffc7201d4dd6e4f3f15..63237e8792e14e1a103d155cefdd0b45f87bd2ab 100644 (file)
@@ -80,6 +80,9 @@ def test_wait_bad(pgconn, waitfn):
 
 
 @pytest.mark.slow
+@pytest.mark.skipif(
+    "sys.platform == 'win32'", reason="win32 works ok, but FDs are mysterious"
+)
 @pytest.mark.parametrize("waitfn", waitfns)
 def test_wait_large_fd(dsn, waitfn):
     waitfn = getattr(waiting, waitfn)
@@ -97,7 +100,7 @@ def test_wait_large_fd(dsn, waitfn):
             assert pgconn.socket > 1024
             pgconn.send_query(b"select 1")
             gen = generators.execute(pgconn)
-            if waitfn is waiting.wait_select and sys.platform != "win32":
+            if waitfn is waiting.wait_select:
                 with pytest.raises(ValueError):
                     waitfn(gen, pgconn.socket)
             else: