]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
libcli/security/dom_sid: remove a couple of lost comments
authorDouglas Bagnall <douglas.bagnall@catalyst.net.nz>
Thu, 16 Mar 2023 02:39:05 +0000 (15:39 +1300)
committerAndrew Bartlett <abartlet@samba.org>
Fri, 28 Apr 2023 02:15:36 +0000 (02:15 +0000)
The second one came with code obsoleting the "BIG NOTE" about 10 years
ago, but that code later wandered off somewhere else.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
libcli/security/dom_sid.c

index 891d3c5e17c7d33fc68ffe127faab158669ed128..7d6b11089cd728e69ba9ea8e36a2f65ff086848a 100644 (file)
@@ -132,7 +132,6 @@ bool dom_sid_parse_endp(const char *sidstr,struct dom_sid *sidout,
 {
        const char *p;
        char *q;
-       /* BIG NOTE: this function only does SIDS where the identauth is not >= 2^32 */
        uint64_t conv;
        int error = 0;
 
@@ -166,7 +165,6 @@ bool dom_sid_parse_endp(const char *sidstr,struct dom_sid *sidout,
                goto format_error;
        }
 
-       /* When identauth >= UINT32_MAX, it's in hex with a leading 0x */
        /* NOTE - the conv value is in big-endian format. */
        sidout->id_auth[0] = (conv & 0xff0000000000ULL) >> 40;
        sidout->id_auth[1] = (conv & 0x00ff00000000ULL) >> 32;