]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
wifi: cfg80211: use strscpy in cfg80211_wext_giwname
authorThorsten Blum <thorsten.blum@linux.dev>
Thu, 28 May 2026 00:10:50 +0000 (02:10 +0200)
committerJohannes Berg <johannes.berg@intel.com>
Thu, 28 May 2026 07:50:42 +0000 (09:50 +0200)
strcpy() has been deprecated [1] because it performs no bounds checking
on the destination buffer, which can lead to buffer overflows.

While the current code works correctly, replace strcpy() with the safer
strscpy() to follow secure coding best practices.

[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strcpy

Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Link: https://patch.msgid.link/20260528001049.1394078-2-thorsten.blum@linux.dev
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
net/wireless/wext-compat.c

index c3aa5697724372fbc1b78b000d80c6683f7fc448..5dbf3ef4b257e2e07cc30b33c60d16f0f57dc680 100644 (file)
@@ -16,6 +16,7 @@
 #include <linux/if_arp.h>
 #include <linux/etherdevice.h>
 #include <linux/slab.h>
+#include <linux/string.h>
 #include <net/iw_handler.h>
 #include <net/cfg80211.h>
 #include <net/cfg80211-wext.h>
@@ -27,7 +28,7 @@ int cfg80211_wext_giwname(struct net_device *dev,
                          struct iw_request_info *info,
                          union iwreq_data *wrqu, char *extra)
 {
-       strcpy(wrqu->name, "IEEE 802.11");
+       strscpy(wrqu->name, "IEEE 802.11");
        return 0;
 }