testutilsqemuschema: Introduce testQEMUSchemaValidateCommand

The new helper splits out all steps necessary to validate a QMP command
against the schema.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>

diff --git a/tests/testutilsqemuschema.c b/tests/testutilsqemuschema.c
index 7b82ff27b27efbbeaf46c0c88f44cac54095ce4f..fe8501f3a0111b69035a1d94d09271515b663546 100644 (file)
--- a/tests/testutilsqemuschema.c
+++ b/tests/testutilsqemuschema.c
@@ -517,6 +517,50 @@ testQEMUSchemaValidate(virJSONValuePtr obj,
 }
 
 
+/**
+ * testQEMUSchemaValidateCommand:
+ * @command: command to validate
+ * @arguments: arguments of @command to validate
+ * @schema: hash table containing schema entries
+ * @debug: a virBuffer which will be filled with debug information if provided
+ *
+ * Validates whether @command and its @arguments conform to the QAPI schema
+ * passed in via @schema. Returns 0, if the command and args match @schema,
+ * -1 if it does not and -2 if there is a problem with the schema or with
+ *  internals.
+ *
+ * @debug is filled with information regarding the validation process
+ */
+int
+testQEMUSchemaValidateCommand(const char *command,
+                              virJSONValuePtr arguments,
+                              virHashTablePtr schema,
+                              virBufferPtr debug)
+{
+    g_autofree char *schemapatharguments = g_strdup_printf("%s/arg-type", command);
+    g_autoptr(virJSONValue) emptyargs = NULL;
+    virJSONValuePtr schemarootcommand;
+    virJSONValuePtr schemarootarguments;
+
+    if (virQEMUQAPISchemaPathGet(command, schema, &schemarootcommand) < 0 ||
+        !schemarootcommand) {
+        virBufferAsprintf(debug, "ERROR: command '%s' not found in the schema", command);
+        return -1;
+    }
+
+    if (!arguments)
+        arguments = emptyargs = virJSONValueNewObject();
+
+    if (virQEMUQAPISchemaPathGet(schemapatharguments, schema, &schemarootarguments) < 0 ||
+        !schemarootarguments) {
+        virBufferAsprintf(debug, "ERROR: failed to look up 'arg-type' of  '%s'", command);
+        return -1;
+    }
+
+    return testQEMUSchemaValidateRecurse(arguments, schemarootarguments, schema, debug);
+}
+
+
 /**
  * testQEMUSchemaGetLatest:
  *

diff --git a/tests/testutilsqemuschema.h b/tests/testutilsqemuschema.h
index 84ee9a9670db5ff1806b57cf74d4955163ebf926..e3a375b038a822bd536a32c6d3167bacce03ec61 100644 (file)
--- a/tests/testutilsqemuschema.h
+++ b/tests/testutilsqemuschema.h
@@ -28,6 +28,12 @@ testQEMUSchemaValidate(virJSONValuePtr obj,
                        virHashTablePtr schema,
                        virBufferPtr debug);
 
+int
+testQEMUSchemaValidateCommand(const char *command,
+                              virJSONValuePtr arguments,
+                              virHashTablePtr schema,
+                              virBufferPtr debug);
+
 virJSONValuePtr
 testQEMUSchemaGetLatest(const char* arch);