]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
iommu/amd: Do not set the D bit on AMD v2 table entries
authorJason Gunthorpe <jgg@nvidia.com>
Fri, 30 Aug 2024 00:06:23 +0000 (21:06 -0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 4 Oct 2024 14:37:41 +0000 (16:37 +0200)
[ Upstream commit 2910a7fa1be090fc7637cef0b2e70bcd15bf5469 ]

The manual says that bit 6 is IGN for all Page-Table Base Address
pointers, don't set it.

Fixes: aaac38f61487 ("iommu/amd: Initial support for AMD IOMMU v2 page table")
Reviewed-by: Vasant Hegde <vasant.hegde@amd.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
Link: https://lore.kernel.org/r/14-v2-831cdc4d00f3+1a315-amd_iopgtbl_jgg@nvidia.com
Signed-off-by: Joerg Roedel <jroedel@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/iommu/amd/io_pgtable_v2.c

index 6088822180e1e483bee7b0959eea5804133211f2..f9227cbf75dfe05e15f496166931955101e4879b 100644 (file)
@@ -51,7 +51,7 @@ static inline u64 set_pgtable_attr(u64 *page)
        u64 prot;
 
        prot = IOMMU_PAGE_PRESENT | IOMMU_PAGE_RW | IOMMU_PAGE_USER;
-       prot |= IOMMU_PAGE_ACCESS | IOMMU_PAGE_DIRTY;
+       prot |= IOMMU_PAGE_ACCESS;
 
        return (iommu_virt_to_phys(page) | prot);
 }