daemon/cgrulesengd: check the bytes read in cgre_receive_unix_domain_msg()

Fix ignoring the number of bytes read, warning reported by Coverity
tool:

CID 258286 (#2 of 2): Ignoring number of bytes read (CHECKED_RETURN).
check_return: read(int, void *, size_t) returns the number of bytes
read, but it is ignored.

In cgre_receive_unix_domain_msg(), the number of bytes read() is
ignored, while reading from the flag value from the socket. Coverity
warns on not checking the number of bytes read, fix it.

Signed-off-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>

diff --git a/src/daemon/cgrulesengd.c b/src/daemon/cgrulesengd.c
index 56fe7c0193ce21c61d2352061721ecf969e468f2..7c514122877c524a97dff6bc1ee27e0d27328768 100644 (file)
--- a/src/daemon/cgrulesengd.c
+++ b/src/daemon/cgrulesengd.c
@@ -607,6 +607,7 @@ static void cgre_receive_unix_domain_msg(int sk_unix)
        char path[FILENAME_MAX];
        struct stat buff_stat;
        socklen_t caddr_len;
+       size_t ret_len;
        int fd_client;
        int flags;
        pid_t pid;
@@ -629,7 +630,8 @@ static void cgre_receive_unix_domain_msg(int sk_unix)
                goto close;
        }
 
-       if (read(fd_client, &flags, sizeof(flags)) < 0) {
+       ret_len = read(fd_client, &flags, sizeof(flags));
+       if (ret_len != sizeof(flags)) {
                flog(LOG_WARNING, "Warning: error reading daemon socket: %s\n", strerror(errno));
                goto close;
        }