]> git.ipfire.org Git - thirdparty/vuejs/router.git/commitdiff
fix: call beforeRouteLeave in right order
authorEduardo San Martin Morote <posva13@gmail.com>
Mon, 6 May 2019 19:24:59 +0000 (21:24 +0200)
committerEduardo San Martin Morote <posva13@gmail.com>
Mon, 6 May 2019 19:24:59 +0000 (21:24 +0200)
__tests__/guards/component-beforeRouteLeave.spec.js
src/router.ts

index 5c7697eb8fb47939a4cd40acdea3f4ae140e0e7a..463899a9d58d6b3609d81eee7330bc303f6308b2 100644 (file)
@@ -150,7 +150,7 @@ describe('beforeRouteLeave', () => {
         )
       })
 
-      it.skip('calls beforeRouteLeave guard on navigation between children in order', async () => {
+      it('calls beforeRouteLeave guard on navigation between children in order', async () => {
         const router = createRouter({ routes })
         await router.push({ name: 'nested-nested-foo' })
         resetMocks()
index 669a99e596d7b1e02500ec586dd6897e47baa158..e41f6c1360dec45996f18726ae42a58013b3ad8c 100644 (file)
@@ -169,7 +169,7 @@ export class Router {
 
     // TODO: is it okay to resolve all matched component or should we do it in order
     guards = await extractComponentsGuards(
-      from.matched.filter(record => to.matched.indexOf(record) < 0),
+      from.matched.filter(record => to.matched.indexOf(record) < 0).reverse(),
       'beforeRouteLeave',
       to,
       from