]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemuValidateDomainVCpuTopology: Remove misconfiguration warning
authorPeter Krempa <pkrempa@redhat.com>
Fri, 21 Jul 2023 07:51:06 +0000 (09:51 +0200)
committerPeter Krempa <pkrempa@redhat.com>
Thu, 24 Aug 2023 12:18:45 +0000 (14:18 +0200)
Since commit baca59a5384 the NUMA definition is automatically fixed if
the vCPU count mismatches the NUMA cpu count so that this warning will
never be triggered.

Additionally VIR_WARN of a misconfiguration of a VM would not really
be seen in most cases as it's only simply logged.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
src/qemu/qemu_validate.c

index 6e4976962d17bea2277b65d9c13078cfb547998e..797caf60768332891753abb52cc608a6f6aeb2d1 100644 (file)
@@ -761,7 +761,6 @@ qemuValidateDomainVCpuTopology(const virDomainDef *def, virQEMUCaps *qemuCaps)
                                                         def->os.machine);
     unsigned int topologycpus;
     unsigned int granularity;
-    unsigned int numacpus;
 
     if (virDomainDefGetVcpus(def) == 0) {
         virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
@@ -785,13 +784,6 @@ qemuValidateDomainVCpuTopology(const virDomainDef *def, virQEMUCaps *qemuCaps)
         }
     }
 
-    numacpus = virDomainNumaGetCPUCountTotal(def->numa);
-    if ((numacpus != 0) && (topologycpus != numacpus)) {
-        VIR_WARN("CPU topology doesn't match numa CPU count; "
-                 "partial NUMA mapping is obsoleted and will "
-                 "be removed in future");
-    }
-
     /* vCPU hotplug granularity must be respected */
     granularity = qemuValidateDefGetVcpuHotplugGranularity(def);
     if ((virDomainDefGetVcpus(def) % granularity) != 0) {