]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s4:libnet: sdb_free_entry() already clears everything
authorStefan Metzmacher <metze@samba.org>
Mon, 21 Feb 2022 22:39:14 +0000 (23:39 +0100)
committerStefan Metzmacher <metze@samba.org>
Thu, 24 Mar 2022 09:19:33 +0000 (09:19 +0000)
There's no need to know about '.free_entry'.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
source4/libnet/libnet_export_keytab.c

index 580281a2062405ce2047da1dd7ea6770e1d5b294..ca76477f329c882da3fb88573a7a5da10d0876bf 100644 (file)
@@ -34,9 +34,7 @@ static NTSTATUS sdb_kt_copy(TALLOC_CTX *mem_ctx,
                            const char *principal,
                            const char **error_string)
 {
-       struct sdb_entry_ex sentry = {
-               .free_entry = NULL,
-       };
+       struct sdb_entry_ex sentry = {};
        krb5_keytab keytab;
        krb5_error_code code = 0;
        NTSTATUS status = NT_STATUS_UNSUCCESSFUL;
@@ -93,9 +91,6 @@ static NTSTATUS sdb_kt_copy(TALLOC_CTX *mem_ctx,
                if (sentry.entry.keys.len == 0) {
                        SAFE_FREE(entry_principal);
                        sdb_free_entry(&sentry);
-                       sentry = (struct sdb_entry_ex) {
-                               .free_entry = NULL,
-                       };
 
                        continue;
                }
@@ -136,9 +131,6 @@ static NTSTATUS sdb_kt_copy(TALLOC_CTX *mem_ctx,
 
                SAFE_FREE(entry_principal);
                sdb_free_entry(&sentry);
-               sentry = (struct sdb_entry_ex) {
-                       .free_entry = NULL,
-               };
        }
 
        if (code != 0 && code != SDB_ERR_NOENTRY) {