]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
power: supply: bq24190: Remove redundant pm_runtime_mark_last_busy() calls
authorSakari Ailus <sakari.ailus@linux.intel.com>
Fri, 4 Jul 2025 07:54:42 +0000 (10:54 +0300)
committerSebastian Reichel <sebastian.reichel@collabora.com>
Sun, 6 Jul 2025 22:56:46 +0000 (00:56 +0200)
pm_runtime_put_autosuspend(), pm_runtime_put_sync_autosuspend(),
pm_runtime_autosuspend() and pm_request_autosuspend() now include a call
to pm_runtime_mark_last_busy(). Remove the now-reduntant explicit call to
pm_runtime_mark_last_busy().

Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Link: https://lore.kernel.org/r/20250704075442.3221283-1-sakari.ailus@linux.intel.com
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
drivers/power/supply/bq24190_charger.c

index 2c3804e1207e5d1d3000cfd6452acb06ec340cc0..e1510c7fdab3bb4312cc8df7f8eed6cd1cc2cef1 100644 (file)
@@ -504,7 +504,6 @@ static ssize_t bq24190_sysfs_show(struct device *dev,
        else
                count = sysfs_emit(buf, "%hhx\n", v);
 
-       pm_runtime_mark_last_busy(bdi->dev);
        pm_runtime_put_autosuspend(bdi->dev);
 
        return count;
@@ -535,7 +534,6 @@ static ssize_t bq24190_sysfs_store(struct device *dev,
        if (ret)
                count = ret;
 
-       pm_runtime_mark_last_busy(bdi->dev);
        pm_runtime_put_autosuspend(bdi->dev);
 
        return count;
@@ -562,7 +560,6 @@ static int bq24190_set_otg_vbus(struct bq24190_dev_info *bdi, bool enable)
        else
                ret = bq24190_charger_set_charge_type(bdi, &val);
 
-       pm_runtime_mark_last_busy(bdi->dev);
        pm_runtime_put_autosuspend(bdi->dev);
 
        return ret;
@@ -605,7 +602,6 @@ static int bq24296_set_otg_vbus(struct bq24190_dev_info *bdi, bool enable)
        }
 
 out:
-       pm_runtime_mark_last_busy(bdi->dev);
        pm_runtime_put_autosuspend(bdi->dev);
 
        return ret;
@@ -638,7 +634,6 @@ static int bq24190_vbus_is_enabled(struct regulator_dev *dev)
                                BQ24190_REG_POC_CHG_CONFIG_MASK,
                                BQ24190_REG_POC_CHG_CONFIG_SHIFT, &val);
 
-       pm_runtime_mark_last_busy(bdi->dev);
        pm_runtime_put_autosuspend(bdi->dev);
 
        if (ret)
@@ -675,7 +670,6 @@ static int bq24296_vbus_is_enabled(struct regulator_dev *dev)
                                BQ24296_REG_POC_OTG_CONFIG_MASK,
                                BQ24296_REG_POC_OTG_CONFIG_SHIFT, &val);
 
-       pm_runtime_mark_last_busy(bdi->dev);
        pm_runtime_put_autosuspend(bdi->dev);
 
        if (ret)
@@ -1376,7 +1370,6 @@ static int bq24190_charger_get_property(struct power_supply *psy,
                ret = -ENODATA;
        }
 
-       pm_runtime_mark_last_busy(bdi->dev);
        pm_runtime_put_autosuspend(bdi->dev);
 
        return ret;
@@ -1419,7 +1412,6 @@ static int bq24190_charger_set_property(struct power_supply *psy,
                ret = -EINVAL;
        }
 
-       pm_runtime_mark_last_busy(bdi->dev);
        pm_runtime_put_autosuspend(bdi->dev);
 
        return ret;
@@ -1682,7 +1674,6 @@ static int bq24190_battery_get_property(struct power_supply *psy,
                ret = -ENODATA;
        }
 
-       pm_runtime_mark_last_busy(bdi->dev);
        pm_runtime_put_autosuspend(bdi->dev);
 
        return ret;
@@ -1713,7 +1704,6 @@ static int bq24190_battery_set_property(struct power_supply *psy,
                ret = -EINVAL;
        }
 
-       pm_runtime_mark_last_busy(bdi->dev);
        pm_runtime_put_autosuspend(bdi->dev);
 
        return ret;
@@ -1861,7 +1851,6 @@ static irqreturn_t bq24190_irq_handler_thread(int irq, void *data)
                return IRQ_NONE;
        }
        bq24190_check_status(bdi);
-       pm_runtime_mark_last_busy(bdi->dev);
        pm_runtime_put_autosuspend(bdi->dev);
        bdi->irq_event = false;
 
@@ -2188,7 +2177,6 @@ static int bq24190_probe(struct i2c_client *client)
 
        enable_irq_wake(client->irq);
 
-       pm_runtime_mark_last_busy(dev);
        pm_runtime_put_autosuspend(dev);
 
        return 0;
@@ -2275,7 +2263,6 @@ static __maybe_unused int bq24190_pm_suspend(struct device *dev)
        bq24190_register_reset(bdi);
 
        if (error >= 0) {
-               pm_runtime_mark_last_busy(bdi->dev);
                pm_runtime_put_autosuspend(bdi->dev);
        }
 
@@ -2300,7 +2287,6 @@ static __maybe_unused int bq24190_pm_resume(struct device *dev)
        bq24190_read(bdi, BQ24190_REG_SS, &bdi->ss_reg);
 
        if (error >= 0) {
-               pm_runtime_mark_last_busy(bdi->dev);
                pm_runtime_put_autosuspend(bdi->dev);
        }