]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
virQEMUBuildNetdevCommandlineFromJSON: Remove unused formatter
authorPeter Krempa <pkrempa@redhat.com>
Fri, 24 Sep 2021 17:00:22 +0000 (19:00 +0200)
committerPeter Krempa <pkrempa@redhat.com>
Tue, 12 Oct 2021 08:26:00 +0000 (10:26 +0200)
Now that everything was replaced by the new code we can remove this
function.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
src/libvirt_private.syms
src/util/virqemu.c
src/util/virqemu.h

index a58f2e455234650666d357986d363207195cb93f..cffd3d638c590ffc7971f4c0d297a081808ec5ad 100644 (file)
@@ -3120,7 +3120,6 @@ virQEMUBuildCommandLineJSONArrayBitmap;
 virQEMUBuildCommandLineJSONArrayNumbered;
 virQEMUBuildCommandLineJSONArrayObjectsStr;
 virQEMUBuildDriveCommandlineFromJSON;
-virQEMUBuildNetdevCommandlineFromJSON;
 
 
 # util/virrandom.h
index ff6e13b963f3c31f500343be951ac9596cfdb274..8119643431f49b255dd0356096f0f510a00f34a9 100644 (file)
@@ -283,36 +283,6 @@ virQEMUBuildCommandLineJSON(virJSONValue *value,
 }
 
 
-/**
- * virQEMUBuildNetdevCommandlineFromJSON:
- * @props: JSON properties describing a netdev
- * @rawjson: don't transform to commandline args, but just stringify json
- *
- * Converts @props into arguments for -netdev including all the quirks and
- * differences between the monitor and command line syntax.
- *
- * @rawjson is meant for testing of the schema in the xml2argvtest
- */
-char *
-virQEMUBuildNetdevCommandlineFromJSON(virJSONValue *props,
-                                      bool rawjson)
-{
-    const char *type = virJSONValueObjectGetString(props, "type");
-    g_auto(virBuffer) buf = VIR_BUFFER_INITIALIZER;
-
-    if (rawjson)
-        return virJSONValueToString(props, false);
-
-    virBufferAsprintf(&buf, "%s,", type);
-
-    if (virQEMUBuildCommandLineJSON(props, &buf, "type",
-                                    virQEMUBuildCommandLineJSONArrayObjectsStr) < 0)
-        return NULL;
-
-    return virBufferContentAndReset(&buf);
-}
-
-
 char *
 virQEMUBuildDriveCommandlineFromJSON(virJSONValue *srcdef)
 {
index b1fc3c8323dac32a2efc95289e8a20d680bd0eea..5098ed7653224c74f89429eed288546f5f93c6e6 100644 (file)
@@ -48,10 +48,6 @@ int virQEMUBuildCommandLineJSON(virJSONValue *value,
                                 const char *skipKey,
                                 virQEMUBuildCommandLineJSONArrayFormatFunc array);
 
-char *
-virQEMUBuildNetdevCommandlineFromJSON(virJSONValue *props,
-                                      bool rawjson);
-
 char *virQEMUBuildDriveCommandlineFromJSON(virJSONValue *src);
 
 void virQEMUBuildBufferEscapeComma(virBuffer *buf, const char *str);