]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
scsi: ufs: Fix wrong value printed in unexpected UPIU response case
authorChanwoo Lee <cw9316.lee@samsung.com>
Wed, 27 May 2026 09:21:34 +0000 (18:21 +0900)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 2 Jun 2026 01:59:00 +0000 (21:59 -0400)
In ufshcd_transfer_rsp_status(), the default case of the inner switch
statement prints the UPIU response code when an unexpected response is
received. However, the code was printing 'result' variable which is
always 0 at that point, making the error message useless for debugging.

Fix this by printing the actual UPIU response code returned by
ufshcd_get_req_rsp().

Fixes: 08108d31129a ("scsi: ufs: Improve type safety")
Signed-off-by: Chanwoo Lee <cw9316.lee@samsung.com>
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Link: https://patch.msgid.link/20260527092134.275887-1-cw9316.lee@samsung.com
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/ufs/core/ufshcd.c

index 9b6cb6b569bc93b7ccc50cd039493ca09fb4f089..3441e874eacc8b98b5b613117ce05c5b04b39dca 100644 (file)
@@ -5716,7 +5716,7 @@ static inline int ufshcd_transfer_rsp_status(struct ufs_hba *hba,
                default:
                        dev_err(hba->dev,
                                "Unexpected request response code = %x\n",
-                               result);
+                               ufshcd_get_req_rsp(lrbp->ucd_rsp_ptr));
                        result = DID_ERROR << 16;
                        break;
                }