[COVERITY] Fix memory leak in e2image

zero_buf and buf must be freed on return from the
output_meta_data_blocks() function.

Coverity ID: 26+27: Resource Leak

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>

diff --git a/misc/ChangeLog b/misc/ChangeLog
index 7c32e5201ece9eed0efd1e967b5e0d01ba6c094d..6ec17336d9d2f9c1fcf94f0d84f387dad70a5440 100644 (file)
--- a/misc/ChangeLog
+++ b/misc/ChangeLog
@@ -1,3 +1,7 @@
+2007-03-21  Theodore Tso  <tytso@mit.edu>
+
+       * e2image.c (output_meta_data_blocks): Fix memory leak.
+
 2007-03-19  Theodore Tso  <tytso@mit.edu>
 
        * mke2fs.c (PRS): Fix deadcode bug detected by Coverity where if

diff --git a/misc/e2image.c b/misc/e2image.c
index a6c42fb0319c192e1062a91b4b536459eb583509..3a080f79e9e2ba5c6e5fd2ccc5783c54fb79c001 100644 (file)
--- a/misc/e2image.c
+++ b/misc/e2image.c
@@ -441,6 +441,8 @@ static void output_meta_data_blocks(ext2_filsys fs, int fd)
                }
        }
        write_block(fd, zero_buf, sparse, 1, -1);
+       free(zero_buf);
+       free(buf);
 }
 
 static void write_raw_image_file(ext2_filsys fs, int fd, int scramble_flag)