]> git.ipfire.org Git - thirdparty/open-vm-tools.git/commitdiff
Fix a stack-use-after-scope issue in FileLockScanDirectory.
authorJohn Wolfe <jwolfe@vmware.com>
Fri, 11 Sep 2020 19:11:02 +0000 (12:11 -0700)
committerJohn Wolfe <jwolfe@vmware.com>
Fri, 11 Sep 2020 19:11:02 +0000 (12:11 -0700)
open-vm-tools/lib/file/fileLockPrimitive.c

index b83f391b80520ef8fa5a88a376a8374bb6e48347..f2054f09eb031db87625fa7db1cec933e8ff1988 100644 (file)
@@ -755,6 +755,7 @@ FileLockScanDirectory(const char *lockDir,      // IN:
       LockValues *ptr;
       Bool       myLockFile;
       LockValues memberValues;
+      char buffer[FILELOCK_DATA_SIZE];
 
       if ((fileList[i] == NULL) || (*fileList[i] == 'E')) {
          continue;
@@ -767,8 +768,6 @@ FileLockScanDirectory(const char *lockDir,      // IN:
          /* It's me! No need to read or validate anything. */
          ptr = myValues;
       } else {
-         char buffer[FILELOCK_DATA_SIZE];
-
          /* It's not me! Attempt to extract the member values. */
          err = FileLockMemberValues(lockDir, fileList[i], buffer,
                                     FILELOCK_DATA_SIZE, &memberValues);